Tong Mu
2.7K posts

Tong Mu
@DKWmt
"DKWings" | @FlutterDev SWE and love it | Former React frontend | 坦诚,豁达,随遇而安
Sunnyvale, CA เข้าร่วม Ağustos 2011
669 กำลังติดตาม1.6K ผู้ติดตาม

@jpohhhh This bug looks like the one fixed by github.com/flutter/flutte…, which has been landed in 3.42. (not on stable yet)
English

Time to play with Liquid Glass in your #FlutterDev app!
I've pushed a prerelease to pub, check it out here: pub.dev/packages/liqui…
It is obviously a first version, so don't expect this to work perfectly, and the API might change a lot still 🥃🥛🥂🍑
English

@imadetheseworks @sethladd @DKWmt is the team member that worked on implementing it.
github.com/flutter/flutte…+
English

@mahersafadii Slightly correction: It’s not because the PR is massive, but the project is massive. Sometimes changes of small LOC can have massive impact and thus must be discussed thoroughly, for example bumping the minimal version of Android. Similar for this one.
English

update: the Flutter team responded, nothing negative so far, they asked him for a design doc because the PR is massive, and the mad lad just finished writing a entire design doc docs.google.com/document/d/1Lf…
Maher Safadi@mahersafadii
First Flutter PR that starts the process of moving Cupertino and Material outside of flutter, its a community one not an official pr, github.com/flutter/flutte…
English

@jezell @mahersafadii Splitting into smaller PRs and steps is also for the convenience of reviewing. Writing something new is hard, and reviewing them is even harder, because reviewers are the last guardians of code correctness. It’s important that reviewers really approve (cont.)
English

@jezell @mickrich384 @mahersafadii We had to write pages of design docs as well. And it’s becaude they really help. I wrote design docs for almost all big projects of mine, and I only regret the cases when I did not write enough - the keyboard was not discussed thoroughly and admittedly it didnt turn out well
English

@mickrich384 @mahersafadii @DKWmt Props to anyone who can get through the process for significant changes. I don’t like the process, but I can respect anyone who puts in the extra work that core team members usually get to skip.
English

@RydMike @mahersafadii @luke_pighetti In my algorithm, assume it has equal x radii and y radii, if 2 r_x >= width, then the width sides are circular arcs. The y sides continue to be continuous rounded borders. (Basically the x and y sides are separated/stitched together.) I'm pretty sure this is how Swiftui works.
English

@mahersafadii @luke_pighetti Also any radius between 0.5x to 1x of stadium border (half of shorter side) will be interesting cases. I have no idea what SwiftUI actually draws for those, but if it is a continous curve, that is not what eg figma_squircle and other in Flutter space does. ⬇️
English

A RoundedSuperEllipse has landed in #Flutter master #issuecomment-2708417645" target="_blank" rel="nofollow noopener">github.com/flutter/flutte…. Looking forward to adding it to my #FlutterDev Squircle study once there is a ShapeBorder for it that we can use #flutter-squircle-status-march-8-2025" target="_blank" rel="nofollow noopener">github.com/rydmike/squirc… The test app for Squircle study is here rydmike.com/squircle/lates…



English

@luke_pighetti @mahersafadii @RydMike During my research I indeed used screenshots of SwiftUI's shapes as reference and derived the formula by pixel comparison. The theoretical result is pretty good (see attached). The PR, though, focus on the practical side, i.e. how it runs in real apps and can be used by users :)

English

@mahersafadii @RydMike i don't like the methodology of comparing two dialogs. someone should do a 256px single corner radius, screenshot, and overlay
English

@HarrySild @RydMike I’m still unsure where the bottleneck is in the Figma Bezier implementation. But yes performance was probably a reason.
English

@RydMike Man finally. It only took how many years after one "mysteriously" closed PR that was supposed to add them. 90% sure the undisclosed mystery had to do with performance cost.
English

@HarrySild Thanks 🙏🙂
Not sure anybody reads it, but just in case 🙂
English

@DeltonDing 目前是推 Peer Review,然後安排 Weekly 的 Review 活動帶大家看(敏捷的 Temperature Reading)
最近新加入的 Junior 有跟我反應不知道怎麼 Review,所以這樣安排讓成員熟悉要注意的地方,還有團隊偏好的做法
中文







