@emilsjolander unfortunately I don't know a better way to debug these issues :( in our case the issues came from OSX showing an auth popup which is very hard to debug without having remote desktop access
English
Rafael de Oleza
1.5K posts
Rafael de Oleza
@rafeca
JS at @stripe
Barcelona, Spain เข้าร่วม Nisan 2007
492 กำลังติดตาม845 ผู้ติดตาม
@rafeca Is there any way to get better logs from the workflow or ssh into the container running my workflow? Because now I just push random code changes and wait an hour to see if it works. Not exactly a quick iteration cycle ^^
English
Anyone in my feed successfully built + notarized an electron/macOS app using GitHub actions ?
English
@emilsjolander I'm glad it helped, did you move away from storing the certificate in base64? That's a pretty neat solution and I'm considering doing the same (we're currently downloading it from a private GitHub repo)
English
@rafeca I honestly don't know what the difference is between this and what I had but I re-wrote our code based on this and now it works. Thanks ^^
English
@ladybenko - big shops usually 8pm, smaller local shops 6-7pm
- modulor is a must for arts and crafts!
- the barn! you can buy them on any of their cafés
have fun in Berlin!!
English
English
Hey @github, do you support vacation notices on repos? Like "During the holiday season we are less likely to respond to issues or PRs, ping x or y for urgent requests" etc?
English
@fatih At Facebook most of the codebase is in the monorepo, which doesn’t have ACLs or any ownership rule (anybody can modify any file), but this requires a very open culture with lots of trust in the engineers
English
Lately I'm thinking about monorepos vs polyrepos (one repo per project) and how it affects orgs. But one thing that I try to understand is how ACL (authorization per project) works on Monorepos. Just read this comment on HN and seems like Google had this problem at some point.
English
@_zamotany @dan_abramov @syke @callstackio @haul Yes you're right, in order to make Metro inline your imports you need your Babel config to leave the imports intact 😅 (it's just that Metro internally uses a Babel plugin to do that inlining), but yeah that's part of the bundling process.
English
@rafeca @dan_abramov @syke @callstackio @haul So either the bundler must support inline requires or allow to modify it's logic. I think that's possible with Webpack, but definitely not straightforward.
English
@_zamotany @dan_abramov @syke @callstackio @haul Still, that's just some babel plugins that interact well with the bundling logic of Metro, so it should be possible to port this to WebPack and other bundlers
English
@_zamotany @dan_abramov @syke @callstackio @haul Yes! actually, we initially tried to use babel's lazy mode but we saw performance regressions (caused by the additional logic that the lazy mode forces to execute very time a require is used). After this, we decided to implement the inlining of import statements inside Metro
English
@_zamotany @dan_abramov @syke @callstackio @haul RAM bundling is a different concept than inline requires (although RAM bundling extremely benefits from inline requires). As far as I know, WebPack/Haul do not support inlining the require/import statements
English
@dan_abramov @syke @callstackio You can either use @haul-bundler/ram-bundle-webpack-plugin (github.com/callstack/haul…) if you just want to use Webpack w/o Haul or add `type: 'indexed-ram-bundle'` or `type: 'file-ram-bundle'` in `haul.config.js` (github.com/callstack/haul…)
English
Rafael de Oleza รีทวีตแล้ว
Six months ago the community told us Hot Reloading was a major pain point. A better Fast Refresh mode is on it's way into React Native. It's resilient to errors (no need for full reloads after a typo) and supports function components with Hooks. Check it out:
English
@cnakazawa @sebmck @mjesun Well it would also get stripped with inlineRequires enabled, since then modules are considered to be without side effects
English
@cnakazawa @sebmck @mjesun On the TypeScript case since it’s a normal import it would not get stripped (unless the babel plugin to strip typescript type definitions also removes the import, which idk if it does)
English
@madbyk @fb_engineering Thanks man! I can tell you that the changes are noticeable! 😁
English
I saw this "Atom is now faster" post title and was a bit skeptical until I saw my old pal @rafeca from @fb_engineering JS Foundation team. Great stuff! :)
github.blog/2019-06-12-ato…
English
English
This is an example of an existing PR where we fixed the git conflicts: github.com/atom/atom/pull…
English
In order to not cause inconvenience to other contributors, I created a (very hacky) semi-automated script to fix the conflicts caused by this commit on existing PRs and I ran it against all the opened PRs that had been updated in the last 6 months.
twitter.com/rafeca/status/…
Rafael de Oleza@rafeca
@marklangovoi Thanks for the suggestion! While rewriting the history may work in some situations, this was done on a big opensource project with almost 8 years of git history, >36K commits and thousands of forks. In this scenario, rewriting would have caused high disruption to the contributors
English