Carter Morgan

i generally dislike code reviews. they used to be something we'd opt to have only when we felt like our changes needed it. then one day everybody decided that mandatory code review should be a thing. i suspect this comes from the OSS community and leaked into professional development. it makes sense in OSS where mandatory code reviews are essential: you're working with a larger team of mostly randos. fallout from bad changes falls on the maintainers and not the contributors, and therefore tighter control is essential. but when you're in a team of 5-7 developers working on a product you're all responsible for the entire concept of code review is different. mix in the usual personality types in the latter scenario and you generally end up with the following types of people: --- - the "i will ignore your PR until i'm free and then 'lgtm'. if this takes a week well that just shows you how important my own work is so fuck you". - the "i see your PR but i have changes in the same area so i'm going to merge my own changes before i event touch your PR. then you can deal with all the merge conflicts. and yes i did privately coordinate approvals of my PR ahead of yours." - the "i pulled your branch and opened it in my IDE and tagged every single warning and suggestion the IDE made, pretended it to be my own. yes, i installed extra tools to increase the feedback. i think i'm a good code reviewer". - the "honestly bro i don't care" type who will let others review and maybe make one comment just so they've been seen to review the code. - the psycho: spends their entire time being toxic in the PR and starting arguments about things that don't matter. --- "ah yes but" you might say "we have standards and patterns that must be adhered to. code reviews are essential for enforcing them". yeah well... the truth is, when you're working in a team you have responsibility for that team's personal development and performance. if you are retroactively pointing out a failure to ensure the team understand the standards your team aheres to then you failed as a leader. most code reviews are performative nonsense to pander to the egos of people who should be improving themselves and their colleagues, not reactively compensating for poor team development. this is a hill and i am prepared to die here.

Annual US spend on… Software: $400B Professional services: $2.8T Logistics labor: $1T+ Healthcare admin: ~$1T Education labor: ~$1T That’s $6T+. Global is probably 3x. Every market is up for grabs. ALL of them. If you don’t get that, you aren’t ready for what’s coming. $650B is a joke.

“You came back… It was me, Murph.” “I knew you’d come back because my dad promised me.”

Overheard in America: "Tyler, stop teasing Cooper. Go play with Hunter, Chandler, and Fletcher instead. And tell Carter, Sawyer, Harper, and Porter to come back and finish their lunch. Piper! Don't let little Dogcatcher run into the street!"