Chad
38 posts
We do the same at 37. Pull requests, especially for more junior staff, is littered with even the most pedantic comments. Style matters. Linters don't capture it all. You learn by being shown the way. This shouldn't be controversial or seen as "toxic".
Dmitrii Kovanikov@ChShersh
Best place I worked in terms of code quality was JetBrains. Every PR I submitted had like 50+ comments from my mentor on how to improve my code. Some might say it’s a toxic culture. But the key point is those comments weren’t rude. I really felt like my IQ grows two points every second. Code quality was unmatched there. The only place where the code was really close to being self-documented.
English
@FitFounder 100% this. I used to be able to run 30 miles in the hills no problem. And at times I thought this kinda hurts (sucks) but it turns out now that I’m working through a calf strain I’d give anything for the privilege of being able to go through the suck again.
English
Announcing random color – a free tool to find a random color.
- exact match domain: $4k aud
- time to build: ~ 1 hour (petite @vuejs)
- monthly searches: ~100k
A simple tool to test how EMD domains actually work.
English
@striver_79 I built a tool that uses AI to do this in case you forget. I'm an indie dev in the "marketing" stage for this product. Any chance you'd like to beta test it?
English
Want to have lesser comments and a faster acceptance rate on your PR?
- Always review it once entirely following the review rules your team follows before sending it out.
English
@burntsushi5 @charliermarsh @pamelafox Commit messages can work... but they aren't displayed in the diff in PRs and they aren't right next to different code sections. So often times it's better to comment right on the diff
English
Very easy way to improve the quality of your work: whenever you put up a PR, take a few seconds to skim through it yourself just as a reviewer would (i.e., in the GitHub UI). I find a surprising number of small issues this way that never stand out in the editor.
English
@pamelafox @charliermarsh Yeah this is another great idea! Really helps speed up the review process for other devs. I started doing that recently and people have commented how much it helps.
English
@charliermarsh Yeah I like to do that I write inline comments explaining things (comments that I don't think need to live in the code forever, but are helpful for reviewer)
English
@charliermarsh This is great advice. And perhaps non-obvious to new developers. I do exactly this. It avoids getting a bunch of "nit - remove this empty line" feedback.
English
@missingfaktor @mausch Hey :) I've built a tool I'm super excited about that actually works! Would you like to get on a call so I could learn more about what you're looking for?
English
Trialing github's copilot PR reviews:
2 PRs, one Python, one C#
It made 3 comments.
All of them complete nonsense. It doesn't even understand C# syntax.
At least it's more concise than CodeRabbit...
Has anyone had any positive experience with any of these AI review tools?
English
Thank you GitHub, but that’s not how we build software. AI should help us focus more on reasoning, design, communication.
Filter spam and unnecessary noise, not helping creating them.
GitHub@github
Generate a summary of a pull request in seconds with GitHub Copilot on GitHub.com. ⚡ Now available for all Individual and Business users. ⬇️
English
@rotimi_best @kettanaito @antfu7 Would love to chat with you about what you'd like this sort of tool to do :) Lmk if that's of interesting. I'd like to build something for it!
English
@kettanaito @antfu7 I'd love to learn more about this problem (and build a tool for you to fix it). Let me know if that's of interest!
English
@antfu7 Imagine using AI to catch and auto-block spam PRs matching a notoriously unpredictable pattern of "Branch N".
English
@antfu7 Yea… It should be the opposite direction. Human describe the problem in PR summary and AI figures out whether the PR achieves the goals and in the optimal way.
English
Just finished V0 of an AI PR review tool:
reviewbot.ai
If you're looking for a way to save you and your developers time on PR reviews let me know!
#buildinpublic
English
Is there an in-person voice recorder with AI summaries, notes, etc?
Like an online meeting AI tool but for real life?
English
@Y2K_mindset If anything the fact that he's almost 50 and has the energy for it seems to back him up. Say what you will about his character but results are results
English
It’s always funny when something like this Andrew Huberman story comes out, or the Tiger Woods scandal years ago. We are supposed to be utterly shocked and appalled that successful men parlayed their success into getting laid.
English